Fix updater file integrity dialog layout #20999
Conversation
plugins/CoreUpdater/Controller.php
Outdated
| @@ -95,7 +97,7 @@ public function getUpdaterJs() | |||
|
|
|||
| $files = array( | |||
| "node_modules/jquery/dist/jquery.min.js", | |||
| "node_modules/jquery-ui-dist/jquery-ui.min.js", | |||
| "node_modules/jquery-ui-dist/jquery-ui.js", | |||
There was a problem hiding this comment.
any reason for switching to the unminified version?
There was a problem hiding this comment.
I must have edited getUpdaterJs() instead of getUpdaterCss() at some point. 🤦 I've reverted it.
|
Nice! One thing to note from the 'after' screenshot — the colour of the close button in modals is usually red. |
|
I overrode the model close button color to green so it matched the color of the other buttons on the page, maybe I should have left it red? We seem to using a few different variations for modals and I though the red was a bit jarring. Not sure if we have a defined UI standard for modals. |
|
Yeah.. the close icon probably should be neutral colour like grey, because it's not a primary action (shouldn't be green) and it's also not an erro/deny action (shouldn't be red), so neither green nor red might be the right one. I'm happy for you or @sgiehl to make the call. |
|
Personally I would simply remove the close button. The modal also closes when clicking |
|
Sounds good, I've removed the red [X] close icon entirely and the 'Ok' button is still green. |
|
@bx80 The padding/margin of the headline could maybe be improved so it is align with the text below. |
|
@sgiehl I've fixed the title alignment |
Description:
Fixes #20961
This PR adds missing CSS classes to the file integrity dialog shown on the updater screen and tweaks the style to better match the rest of the UI. Includes a new UI test to prevent future regression.
Before:
After:
Review