Add link to MySQL docs for max_packet_size diagnostic warning #20990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does the same docs apply to different versions of MySQL? That's the only reason why I didn't pick this up as I wasn't sure whether we should e.g. link to an FAQ page with different links for different MySQL versions. |
|
I did think about having different links depending on the database engine, but we don't have any proper system for detecting different database types and this config setting is exactrly the same for MySQL 5.x, 8.x and MariaDb, so the MySQL 8.x documentation page will work for all. Later on when we implement more database abstraction then this link could be provided by the database driver. |
Co-authored-by: Michal Kleiner <michal@innocraft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #20970
This PR simply adds a link to the MySQL docs for the
max_packet_sizediagnostic warning.Translation file were updated because this adds two placeholders for the link, existing placeholder were renumbered but no language changes were made.
Review