Description:

Fixes #20894

This can take a bit of time to recreate, I used the event report and clicked repeatedly on the first label to expand and collapse it:

Eventually the label disappears:

The label is disappearing because the column width is being set to zero by the resizeDataTable() event, a minimum label size is passed to getLabelWidth() but this method sometimes incorrectly calculates a zero width value from existing DOM elements. I suspect that this could be race condition between the row collapse and resize table events.

This PR adds a check to the getLabelWidth() method to prevent zero values being returned and instead falls back to the passed minLabelWidth value. After this change I was no longer able to recreate the issue, despite much clicking.

Review

• Functional review done
• Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
• Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
• Security review done
• Wording review done
• Code review done
• Tests were added if useful/possible
• Reviewed for breaking changes
• Developer changelog updated if needed
• Documentation added if needed
• Existing documentation updated if needed