Introduce stylelint to lint css / less files #20926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1878525 to
5721ca6
Compare
|
@bx80 @michalkleiner Any thoughts about this one? I've added a temporary commit, that introduces the usage of an invalid hex color, as that is currently the only rule that is checked. You can see the automatic comment in the changed files in this PR. |
|
Yep, generally in favour of this 👍 |
bx80
approved these changes
Jun 25, 2023
Co-authored-by: Ben Burgess <88810029+bx80@users.noreply.github.com>
michalkleiner
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
While looking through our CSS / LESS files I came across a couple of rules, that were incorrect, duplicate or useless.
Some of this problems would have been easily discover-able using a linter.
This PR introduces the usage of stylelint (https://stylelint.io/) to improve that.
I've only included one rule for now, so this PR doesn't contain any code changes. I'll create follow-up PRs later to also include some rules that will require adjustments in the css/less files.
Note: We shouldn't use stylelint to force a certain formatting of such files. Stylelint deprecated all rules around that in favor of using tools like prettier. We can consider implementing that one as well later.
Review