Skip to content

Fix drag&drop in datatable search bar #20905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2023
Merged

Fix drag&drop in datatable search bar #20905

merged 1 commit into from
Jun 20, 2023

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jun 16, 2023

Description:

fixes #20640

Review

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Jun 16, 2023
@sgiehl sgiehl added this to the 5.0.0 milestone Jun 16, 2023
@michalkleiner
Copy link
Contributor

I was briefly looking into this as well and didn't think of using the draggable attribute, well done! I was thinking to actually update the CSS so that the search form wasn't inside the a element which would probably be more usable/appropriate solution (and to also not use a tags where buttons should be used, but that's for another discussion).

michalkleiner
michalkleiner approved these changes Jun 19, 2023
View reviewed changes
Copy link
Contributor

@michalkleiner michalkleiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and I even though dropping other links to the field still works (as any other text), dragging within the field doesn't drop the link there anymore and works as expected.

@sgiehl sgiehl merged commit aa9a2b3 into 5.x-dev Jun 20, 2023
@sgiehl sgiehl deleted the m20640 branch June 20, 2023 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalkleiner michalkleiner michalkleiner approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

UX: Search bar javascript issue
2 participants
@sgiehl @michalkleiner