-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Add instruction tab for React.js to no data screen & improve JS code instruction tab #20890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Stefan Giehl <stefan@matomo.org>
@AltamashShaikh I think the TagManager submodule reference might need updating in this PR? I got this error when loading the no-data react tab:
The same error is shown on the UI tests. Running You probably need to do something like:
Which should update this PR to reference the 4.x-dev branch for TagManager and fix the UI test. |
@bx80 updated submodule as suggested |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only had a rough look through the code and did some quick testing in the UI, as those changes should already have been reviewed in detail for 5.x-dev. Looks good for me though.
Description:
Merged React no data screen and JS code cleanup.
Fixes: #PG-2779, #PG-2799
Review