Skip to content

Disable save button, while a site is being saved #20879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 15, 2023
Merged

Disable save button, while a site is being saved #20879

merged 1 commit into from
Jun 15, 2023

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jun 12, 2023

Description:

fixes #20838

Review

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Jun 12, 2023
@sgiehl sgiehl added this to the 5.0.0 milestone Jun 12, 2023
@sgiehl sgiehl requested review from michalkleiner and bx80 June 14, 2023 16:10
bx80
bx80 approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@bx80 bx80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tested well for me, before the change it's possible to click the save button multiple times, afterwards it is immediately disabled 👍

@sgiehl sgiehl merged commit 0026322 into 5.x-dev Jun 15, 2023
@sgiehl sgiehl deleted the m20838 branch June 15, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalkleiner michalkleiner Awaiting requested review from michalkleiner

1 more reviewer

@bx80 bx80 bx80 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

When adding a website, it adds it twice instead of once
2 participants
@sgiehl @bx80