Skip to content

React steps updated for history change step, #PG-2779 #20878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 14, 2023
Merged

React steps updated for history change step, #PG-2779 #20878

merged 3 commits into from
Jun 14, 2023

Conversation

AltamashShaikh
Copy link
Contributor

@AltamashShaikh AltamashShaikh commented Jun 12, 2023 •
edited
Loading

Description:

React steps updated for history change step
Fixes: #PG-2779.
Depends on: matomo-org/tag-manager#643

Review

@AltamashShaikh AltamashShaikh added the Needs Review PRs that need a code review label Jun 14, 2023
@AltamashShaikh AltamashShaikh requested review from sgiehl and bx80 June 14, 2023 06:13
@AltamashShaikh AltamashShaikh marked this pull request as ready for review June 14, 2023 06:13
@sgiehl
Copy link
Member

sgiehl commented Jun 14, 2023

@AltamashShaikh I don't understand the purpose of this changes. In theory the TagManager can always be disabled on an instance. If that is the case, the react tab would then be empty. Is that intended?
If the react tab is only useful when using tag manager, then the tab should be inserted using the tag manager and not only it's content

@AltamashShaikh
Copy link
Contributor Author

@AltamashShaikh I don't understand the purpose of this changes. In theory the TagManager can always be disabled on an instance. If that is the case, the react tab would then be empty. Is that intended? If the react tab is only useful when using tag manager, then the tab should be inserted using the tag manager and not only it's content

@sgiehl We have this check to ensure react tab is shown only when TagManager is active

@AltamashShaikh AltamashShaikh mentioned this pull request Jun 14, 2023
Merged
@sgiehl
Copy link
Member

sgiehl commented Jun 14, 2023

Ok. Than this might work. Even though it's not very elegant to have stuff in core, that is only filled up when a certain plugin is active. But we can consider refactoring that at a later point.

@sgiehl sgiehl added this to the 5.0.0 milestone Jun 14, 2023
@sgiehl sgiehl added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jun 14, 2023
@sgiehl sgiehl merged commit 323447b into 5.x-dev Jun 14, 2023
@sgiehl sgiehl deleted the PG-2779-react-followup branch June 14, 2023 15:45
AltamashShaikh added a commit that referenced this pull request Jun 15, 2023
@AltamashShaikh @sgiehl
React steps updated for history change step, #PG-2779 (#20878)
de596b2 
Co-authored-by: Stefan Giehl <stefan@matomo.org>
sgiehl added a commit that referenced this pull request Jun 19, 2023
@AltamashShaikh @sgiehl
Merged React no data screen and JS code cleanup (#20890)
160a170 
* Merged React no data screen

* Fixes for testcase to work

* Fix for tracking code page

* Merged JS code cleanup changes

* UI screenshot updated

* Updated UI screenshot

* React steps updated for history change step, #PG-2779 (#20878)

Co-authored-by: Stefan Giehl <stefan@matomo.org>

* Updated submodule

* Updated UI screenshot

* update expected UI file

---------

Co-authored-by: Stefan Giehl <stefan@matomo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

@bx80 bx80 Awaiting requested review from bx80

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@AltamashShaikh @sgiehl