Skip to content

Improve handling of incompatible plugins during an update #20868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 10, 2023
Merged

Improve handling of incompatible plugins during an update #20868

merged 10 commits into from
Jul 10, 2023

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jun 9, 2023 •
edited
Loading

Description:

Incompatible plugins can currently break the updating process, as the process might try to disable them within the process that is still running with old code. If disabling the plugin triggers code, that was not yet loaded, new files might get loaded, that contain code that can't work with the previously loaded old code.

This PR adds a new set of UI tests that will perform an update from the last (forced) Matomo version. Currently this is 4.15.0.
Note: Running this new tests with updating from 4.14.x resulted in errors, which are now fixed with using 4.15.x

Review

@sgiehl sgiehl force-pushed the improveupdater branch 30 times, most recently from ed0c3cd to ebccc8d Compare June 12, 2023 11:45
@sgiehl sgiehl force-pushed the improveupdater branch 10 times, most recently from e3d686b to 8ba0b4d Compare June 16, 2023 14:59
@sgiehl sgiehl added this to the 5.0.0 milestone Jun 26, 2023
@sgiehl sgiehl marked this pull request as ready for review July 7, 2023 08:43
@sgiehl sgiehl added the Needs Review PRs that need a code review label Jul 7, 2023
@sgiehl sgiehl requested review from michalkleiner and bx80 July 7, 2023 08:46
michalkleiner
michalkleiner reviewed Jul 7, 2023
View reviewed changes
bx80
bx80 approved these changes Jul 9, 2023
View reviewed changes
Copy link
Contributor

@bx80 bx80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This worked for me when updating a 4.15 install with an incompatible plugin, the plugin was disabled and the update completed successfully. Automated tests are all looking good and I can't see any other issues 👍

@sgiehl sgiehl merged commit c4b63d4 into 5.x-dev Jul 10, 2023
@sgiehl sgiehl deleted the improveupdater branch July 10, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalkleiner michalkleiner michalkleiner left review comments

+1 more reviewer

@bx80 bx80 bx80 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@sgiehl @michalkleiner @bx80