Improvements to notifications under tracking code on no data screen #20862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Merged multiple notifications under tracking code into one, #PG-2827 * Updated UI screenshot * design changes for notification bar * Updated UI screenshot * Improvements around translatio for guides * PR changes * Updated UI tests * Changes to incoprate consentManager connected * UI tests updated * Updated site_Type for test * Updated UI screenshot * Ampersand translated * Notifications logic updated * typo fixed * Twig varibale not defined fixed * UI tests fixed * UI screenshot updated * Started using createAndListing() instead of General_And * PR changes
AltamashShaikh
commented
Jun 9, 2023
| } | ||
|
|
||
| if (!empty($message)) { | ||
| $bannerMessage = implode(' ' . Piwik::translate('General_And') . ' ', $message); |
There was a problem hiding this comment.
@michalkleiner changed to use the translation in 4.x-dev
bx80
approved these changes
Jun 12, 2023
There was a problem hiding this comment.
This all looks good to me and the relevant tests are all passing. This is a cherry pick of changes already merged to 5.x-dev so the code has already been through a previous round of reviews 👍
- Functional review done
- Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
- Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
- Security review done
- Wording review done
- Code review done
- Tests added 👍 Tests were added if useful/possible
- None Reviewed for breaking changes
- Not needed Developer changelog updated if needed
- n/a Documentation added if needed
- n/a Existing documentation updated if needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Merged multiple notifications under tracking code into one.
Fixes: #PG-2827
Review