Skip to content

remove setting a revised property #20850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 8, 2023
Merged

remove setting a revised property #20850

merged 1 commit into from
Jun 8, 2023

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jun 7, 2023

Description:

that property doesn't exist anywhere else in Matomo, so should be safe so simply remove it.

fixes #20845

Review

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Jun 7, 2023
@sgiehl sgiehl added this to the 5.0.0 milestone Jun 7, 2023
@michalkleiner
Copy link
Contributor

Had a look at the original PR that introduced the property and the current code base and also couldn't find any current uses.

@michalkleiner michalkleiner merged commit 519f22a into 5.x-dev Jun 8, 2023
@michalkleiner michalkleiner deleted the m20845 branch June 8, 2023 00:41
@mneudert mneudert mentioned this pull request Nov 15, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalkleiner michalkleiner michalkleiner approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

[PHP 8.2 compatibility] WARNING: Deprecated - Creation of dynamic property
2 participants
@sgiehl @michalkleiner