add actions goal metrics to processed reports in metadata and report data #20817
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Special goal metrics added in AddColumnsProcessedMetricsGoal are not currently displaying in processed report output, but they need to be for API consumers like the Looker Studio connector to be able to use them. This PR makes sure they are in report metadata for the appropriate Actions reports, and are calculated properly when requesting processed report data.
Changes:
processOnlyIdGoal
inAddColumnsProcessedMetricsGoal
should be from theGoals
visualization toAddColumnsProcessedMetricsGoal
.ProcessedReport
to compute the correct methods for Actions processed reports.AddColumnsProcessedMetricsGoal
are included in report metadata for the appropriate Actions reports.GOALS_ENTRY_PAGES_ECOMMERCE
instead ofGOALS_PAGES_ECOMMERCE
.Requested by @mattab for the Looker Studio connector.
Review