Skip to content

Configure linguist to exclude libs, generated and resource files #20813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

rr-it
Copy link
Contributor

@rr-it rr-it commented May 31, 2023

Description:

Configure linguist to exclude libs/vendor, generated and resource files from language statistics.

This surpresses the display of generated files in diffs:
*.min.css, *.min.js, /matomo.js, /piwik.js, plugins/*/vue/dist

And it makes for a more meaningful language statistic on this repository.
Current state:

grafik

Review

@sgiehl
Copy link
Member

sgiehl commented Jun 1, 2023

Hi @rr-it,

I actually wasn't aware of this possibility before. To me it looks useful.
I'm not yet sure if the list of files and folders is complete, but I'll merge it now and we can see afterwards if the list might need to be adjusted again.

Thanks for your contribution 🎉

@sgiehl sgiehl merged commit c5da2b4 into matomo-org:5.x-dev Jun 1, 2023
@sgiehl sgiehl added this to the 5.0.0 milestone Jun 1, 2023
@sgiehl sgiehl added the c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. label Jun 1, 2023
@sgiehl
Copy link
Member

sgiehl commented Jun 1, 2023

Interesting how that changes the language stats:

image

@rr-it rr-it deleted the dev/linguist-exclude-from-language-statistic branch June 5, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues.
Development

Successfully merging this pull request may close these issues.

2 participants