Ensure Installation sets trusted host including port number if available #20807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
commented
May 31, 2023
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
michalkleiner
approved these changes
Jun 7, 2023
|
The change works as expected, I wonder where/how can we cover it with a test? |
|
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
|
I guess the only possibility to cover that with tests would be to adjust our UI tests, so they run on a webserver with a custom port. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
fixes #9549
Review