Added site detection for Vue and added relevant tab and info #20781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
requested changes
May 24, 2023
sgiehl
requested changes
May 25, 2023
sgiehl
requested changes
May 25, 2023
|
@sgiehl updated tests, should be good to merge now once all the test cases passes 👍 |
bx80
approved these changes
May 26, 2023
There was a problem hiding this comment.
This looks good to me 👍 The related tests are all passing and I can't see any issues when checking detection manually.
- Functional review done
- Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
- Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
- Security review done
- All looks good Wording review done
- Code review done
- Tests added and updated Tests were added if useful/possible
- None Reviewed for breaking changes
- n/a Developer changelog updated if needed
- n/a Documentation added if needed
- n/a Existing documentation updated if needed
michalkleiner
approved these changes
May 26, 2023
…tomo into PG-2778-vue-no-data-screen
|
Apologies @AltamashShaikh, a few minor things to look at. Generally it's all good though! |
michalkleiner
approved these changes
May 26, 2023
AltamashShaikh
added a commit
that referenced
this pull request
May 26, 2023
…nfo (#20781) * Added site detection for Vue and added relevant tab and info, #PG-2778 * Minor fix * Updated UI screenshots * Minor fix * Added FAQ link and PR feedback applied * Removed extra spaces and styling changes * Textual update * Updated UI screenshots * Changed to JS_FRAMEWORK instead of vue * Fixed type in methhod name * Updated note2 to not include support for on premise * Updated screenshots * Fix accidental typo in English lang string * Updated UI screenshot * Added z-index for fixed footer no data screen * PR feedback applied * updated screenshot --------- Co-authored-by: Michal Kleiner <michal@innocraft.com>
sgiehl
added a commit
that referenced
this pull request
May 26, 2023
* Add site detection for Vue.js, with no data screen tab and tracking info (#20781) * Added site detection for Vue and added relevant tab and info, #PG-2778 * Minor fix * Updated UI screenshots * Minor fix * Added FAQ link and PR feedback applied * Removed extra spaces and styling changes * Textual update * Updated UI screenshots * Changed to JS_FRAMEWORK instead of vue * Fixed type in methhod name * Updated note2 to not include support for on premise * Updated screenshots * Fix accidental typo in English lang string * Updated UI screenshot * Added z-index for fixed footer no data screen * PR feedback applied * updated screenshot --------- Co-authored-by: Michal Kleiner <michal@innocraft.com> * Changes to make it compatible for 4.x-dev * fix test * fix test --------- Co-authored-by: Michal Kleiner <michal@innocraft.com> Co-authored-by: Stefan Giehl <stefan@matomo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added site detection for Vue and added relevant tab and info.
Fixes: #PG-2778, #PG-2749 style changes
Review