Skip to content

Allow to optionally defer JS from custom layout templates #20750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

michalkleiner
Copy link
Contributor

Description:

Since login page doesn't use nearly any of the bundled JS, we can defer its loading and the form will still be visible quite early. Then with the JS already loaded continuing to the dashboard should use the cached files already.

Review

@michalkleiner michalkleiner added the Needs Review PRs that need a code review label May 18, 2023
@michalkleiner michalkleiner added this to the 5.0.0 milestone May 18, 2023
@michalkleiner michalkleiner added the c: Performance For when we could improve the performance / speed of Matomo. label May 18, 2023
@michalkleiner
Copy link
Contributor Author

Relates to #20460

@michalkleiner
Copy link
Contributor Author

Some of the failing UI tests are related to the change. Will work on this further.

@michalkleiner michalkleiner marked this pull request as draft May 19, 2023 11:12
@sgiehl sgiehl force-pushed the feature/DEV-16540-defer-js-on-login-page branch from e82f520 to c9a2c73 Compare May 25, 2023 15:33
@michalkleiner michalkleiner force-pushed the feature/DEV-16540-defer-js-on-login-page branch from c9a2c73 to 0399117 Compare May 29, 2023 11:22
@michalkleiner
Copy link
Contributor Author

Replaced by #20809 due to a source branch name change.

@michalkleiner michalkleiner deleted the feature/DEV-16540-defer-js-on-login-page branch May 31, 2023 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Performance For when we could improve the performance / speed of Matomo.
Development

Successfully merging this pull request may close these issues.

1 participant