Skip to content

Update Google Tag Manager instructions on no data screen #20710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 12, 2023

Conversation

michalkleiner
Copy link
Contributor

Description:

Adding new steps 2 and 4 while removing old steps 9 and 10 steps related to GTM container preview, as required by product team.

Translations to other languages to follow with other translations in the #20704 PR.

Review

@michalkleiner michalkleiner added the Needs Review PRs that need a code review label May 12, 2023
Copy link
Contributor

@AltamashShaikh AltamashShaikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here update the failing UI tests

@AltamashShaikh
Copy link
Contributor

@michalkleiner The changes should have been added in 5.x-dev first and later cherrypicked into 4.x-dev

@michalkleiner michalkleiner force-pushed the DEV-16752-remove-preview-steps branch 2 times, most recently from e1f338a to 3f4b701 Compare May 12, 2023 08:22
@michalkleiner michalkleiner changed the title Remove steps relating to GTM container preview and adjust wording of other steps [4.x] Remove steps relating to GTM container preview and adjust wording of other steps May 12, 2023
…other steps

Renaming the translation keys as well as the content changed significantly since there
were steps added and removed.
@michalkleiner michalkleiner force-pushed the DEV-16752-remove-preview-steps branch from 3f4b701 to 07ea708 Compare May 12, 2023 09:24
@sgiehl sgiehl added this to the 4.14.x milestone May 12, 2023
@sgiehl sgiehl merged commit a9b4945 into 4.x-dev May 12, 2023
@sgiehl sgiehl deleted the DEV-16752-remove-preview-steps branch May 12, 2023 11:22
@sgiehl sgiehl changed the title [4.x] Remove steps relating to GTM container preview and adjust wording of other steps Update Google Tag Manager instructions on no data screen Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Development

Successfully merging this pull request may close these issues.

3 participants