Skip to content

Conversation

michalkleiner
Copy link
Contributor

Description:

Add translations for GTM tab of the no-data screen.
Companion PR to #20637 for 4.x branch

Review

@michalkleiner
Copy link
Contributor Author

Please don't merge until the 5.x PR is approved by the product team and merged.

@michalkleiner michalkleiner changed the title Add German, Spanish, French, Italian and Dutch translation for no-data GTM page [4.x] Add German, Spanish, French, Italian and Dutch translation for no-data GTM page May 12, 2023
@michalkleiner michalkleiner marked this pull request as draft May 12, 2023 08:26
@michalkleiner michalkleiner force-pushed the feature/DEV-16595-4.x-translations branch from a58f1d1 to bfad657 Compare May 15, 2023 12:37
@Findus23
Copy link
Collaborator

Just in case you don't know it: You can use the Weblate glossary (https://hosted.weblate.org/projects/matomo/glossary/) to make sure "special Matomo phrases" like "Custom Dimensions" are translated the same here as everywhere else in Matomo (If you manage the translations via the Weblate UI, it also automatically suggests the glossary phrases)

@michalkleiner michalkleiner force-pushed the feature/DEV-16595-4.x-translations branch from 1dc7942 to 83c768f Compare May 19, 2023 10:39
@michalkleiner
Copy link
Contributor Author

Failing tests are pre-existing/failing on the base 4.x-dev branch as well.

@michalkleiner michalkleiner marked this pull request as ready for review May 19, 2023 11:38
@michalkleiner michalkleiner requested a review from sgiehl May 19, 2023 11:38
@michalkleiner
Copy link
Contributor Author

5.x PR #20637 already merged

@sgiehl sgiehl merged commit b176d3b into 4.x-dev May 19, 2023
@sgiehl sgiehl deleted the feature/DEV-16595-4.x-translations branch May 19, 2023 12:33
@sgiehl sgiehl added this to the 4.14.x milestone May 25, 2023
@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. c: i18n For issues around internationalisation and localisation. labels Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: i18n For issues around internationalisation and localisation. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Development

Successfully merging this pull request may close these issues.

3 participants