Prevent duplicate dates for the purge old archive data command #20699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @bx80, that's a nice little tweak that can potentially make a big difference! What do you think about an alternative approach of making the list unique just before it's returned? That way it would also cover the other branch of the conditional logic there. - return $dates;
+ return array_unique($dates); |
|
What @michalkleiner suggested makes sense. And to avoid iterating over numeric and blob tables you could also change it to use |
sgiehl
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When using the
./console core:purge-old-archive-data allcommand the list of archive dates to purge is generated by iterating through the existing archive tables, however since there can be both blob and numeric archive tables this results in each date being added twice to the list. Then every archive purge and table optimization is unnecessarily performed twice.This PR simply checks the dates array as it is being generated and prevents duplicates date being added.
Although the
getTablesArchivesInstalled()method used to retrieve the list of table could be called with a single table type (e.g. just return blob tables) this wouldn't cover scenarios where archive tables only existed of one type for a date.Fixes #20692
Review