Skip to content

Allow reports to override the min/max label width values #20682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 8, 2023
Merged

Allow reports to override the min/max label width values #20682

merged 2 commits into from
May 8, 2023

Conversation

diosmosis
Copy link
Member

Description:

See #20643

Review

@diosmosis diosmosis added the Needs Review PRs that need a code review label May 7, 2023
@diosmosis diosmosis added this to the 4.14.x milestone May 7, 2023
@diosmosis diosmosis changed the title Apply 20643 to 4.x-dev - Allow reports to override the min/max label width values Apply #20643 to 4.x-dev - Allow reports to override the min/max label width values May 7, 2023
michalkleiner
michalkleiner approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@michalkleiner michalkleiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @diosmosis, the change replicates what has been approved and merged for 5.x so it is good to go.

@michalkleiner michalkleiner merged commit ce758f8 into 4.x-dev May 8, 2023
@michalkleiner michalkleiner deleted the apply-20643 branch May 8, 2023 06:45
@sgiehl sgiehl changed the title Apply #20643 to 4.x-dev - Allow reports to override the min/max label width values Allow reports to override the min/max label width values Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalkleiner michalkleiner michalkleiner approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Milestone
4.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@diosmosis @michalkleiner