Skip to content

Conversation

diosmosis
Copy link
Member

Description:

If a plugin has no category with less than 4 reports, the widget menu code will end up creating a Category with no reports in the widget selector:

image

vs.

image

This PR avoids creating empty categories.

Should probably be replicated on 4.x-dev after merging.

Review

@diosmosis diosmosis added the Needs Review PRs that need a code review label May 3, 2023
@diosmosis diosmosis added this to the 5.0.0 milestone May 3, 2023
@sgiehl sgiehl merged commit 5793f26 into 5.x-dev May 4, 2023
@sgiehl sgiehl deleted the widget-menu-empty-cats branch May 4, 2023 09:11
@sgiehl sgiehl added Bug For errors / faults / flaws / inconsistencies etc. c: Design / UI For issues that impact Matomo's user interface or the design overall. and removed Needs Review PRs that need a code review labels May 4, 2023
@sgiehl sgiehl added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Design / UI For issues that impact Matomo's user interface or the design overall. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Development

Successfully merging this pull request may close these issues.

2 participants