Skip to content

Fix array access issue for a single goal ID only #20638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2023
Merged

Fix array access issue for a single goal ID only #20638

merged 1 commit into from
May 2, 2023

Conversation

michalkleiner
Copy link
Contributor

@michalkleiner michalkleiner commented Apr 26, 2023 •
edited by sgiehl
Loading

Description:

Fix for an array access issue introduced in #20438 where a single goal produces a numeric value straight away, not an array.

fixes #20636

Review

@michalkleiner michalkleiner added the Needs Review PRs that need a code review label Apr 26, 2023
@michalkleiner michalkleiner added this to the 5.0.0 milestone Apr 26, 2023
@michalkleiner michalkleiner added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Apr 26, 2023
@michalkleiner michalkleiner mentioned this pull request Apr 26, 2023
Closed
@michalkleiner
Copy link
Contributor Author

UI test failures are unrelated

@sgiehl sgiehl force-pushed the bugfix/20636-array-access branch from 2ca6daf to 055c50e Compare May 2, 2023 12:16
@sgiehl sgiehl merged commit 94450ef into 5.x-dev May 2, 2023
@sgiehl sgiehl deleted the bugfix/20636-array-access branch May 2, 2023 12:52
@diosmosis diosmosis mentioned this pull request May 7, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

[PHP 8.1 compatibility] Fix array access warning on float - /plugins/Goals/DataTable/Filter/CalculateConversionPageRate.php
2 participants
@michalkleiner @sgiehl