Skip to content

No-data GTM screen translations #20637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 19, 2023
Merged

No-data GTM screen translations #20637

merged 6 commits into from
May 19, 2023

Conversation

michalkleiner
Copy link
Contributor

Description:

Add translations for GTM tab of the no-data screen.

Review

@michalkleiner michalkleiner added the Needs Review PRs that need a code review label Apr 26, 2023
@michalkleiner
Copy link
Contributor Author

The translations are pending product team review, so please don't merge until they are confirmed to be correct.

@michalkleiner michalkleiner added BHAG-Tracking-OKR-Q2 and removed Needs Review PRs that need a code review labels Apr 27, 2023
@michalkleiner michalkleiner force-pushed the feature/DEV-16595-translations branch from 4693a1f to 3f4feba Compare May 11, 2023 14:24
@michalkleiner michalkleiner mentioned this pull request May 11, 2023
Merged
11 tasks
@michalkleiner michalkleiner force-pushed the feature/DEV-16595-translations branch from 3f4feba to 7071111 Compare May 15, 2023 05:59
@sgiehl sgiehl added this to the 5.0.0 milestone May 17, 2023
@michalkleiner michalkleiner force-pushed the feature/DEV-16595-translations branch from c4b35b5 to f319b8f Compare May 18, 2023 10:35
@michalkleiner michalkleiner requested a review from sgiehl May 18, 2023 11:15
@michalkleiner
Copy link
Contributor Author

Failing tests are already failing on 5.x-dev and are unrelated to this PR so it's not for this PR to address that.
Let's get this reviewed and merged since it's causing a lot of troubles rebasing and reviewing locally every time a new addition is added to the no-data screen.

@michalkleiner
Copy link
Contributor Author

Internal ref. for context: DEV-16595

@michalkleiner michalkleiner added the Needs Review PRs that need a code review label May 18, 2023
@sgiehl sgiehl force-pushed the feature/DEV-16595-translations branch from 60b05a5 to 9b5fde6 Compare May 19, 2023 09:23
sgiehl
sgiehl approved these changes May 19, 2023
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked through all the languages and the GTM part is translated as expected. Will merge this PR and mark the translations as reviewed on weblate

@sgiehl sgiehl merged commit dd09c1f into 5.x-dev May 19, 2023
@sgiehl sgiehl deleted the feature/DEV-16595-translations branch May 19, 2023 09:42
@michalkleiner
Copy link
Contributor Author

Thanks @sgiehl. I will update the PR for 4.x-dev branch as well.

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. and removed Needs Review PRs that need a code review labels May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@michalkleiner @sgiehl