Added WordPress installation guide for no-data and tracking code pages #20630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snake14
requested changes
Apr 27, 2023
snake14
reviewed
Apr 27, 2023
plugins/SitesManager/lang/en.json
Outdated
| @@ -158,6 +158,31 @@ | |||
| "SiteWithoutDataGoogleTagManagerFollowStep9": "Preview your changes by clicking the \"Preview\" button.", | |||
| "SiteWithoutDataGoogleTagManagerFollowStep10": "Check if the Matomo tag is firing as expected.", | |||
| "SiteWithoutDataGoogleTagManagerFollowStep11": "Publish your changes by clicking the \"Submit\" button and then the \"Publish\" button at the top right.", | |||
| "SiteWithoutDataGoogleTagManagerFollowStepCompleted": "%1$sCongratulations!%2$s You have successfully installed the Matomo Analytics tracking code via Google Tag Manager. To verify that hits are being tracked, visit your website and check that this data is visible in your Matomo instance." | |||
| "SiteWithoutDataGoogleTagManagerFollowStepCompleted": "%1$sCongratulations!%2$s You have successfully installed the Matomo Analytics tracking code via Google Tag Manager. To verify that hits are being tracked, visit your website and check that this data is visible in your Matomo instance.", | |||
| "WordpressDetected": "Wordpress was detected on your website. Did you know you can use the Matomo easy WordPress plugin to track the website data? %1$sLearn more in this guide%2$s.", | |||
There was a problem hiding this comment.
The phrase the Matomo easy WordPress plugin sounds a little funny. I think that the easy Matomo WordPress plugin or maybe you can easily use the Matomo plugin for WordPress.
There was a problem hiding this comment.
Yep, this would be great to have reworded.
I would also suggest to ask the product team to review the whole content by providing them with a screenshot of the UI in the internal ticket.
There was a problem hiding this comment.
@snake14 Updated as suggested and @michalkleiner The text was provided by the product team only
There was a problem hiding this comment.
Looks good. The main issue I saw was that the Matomo Url is partially unreadable:
@snake14 This looks specific to your setup works fine for me, even the UI screenshot seems to display it correctly
snake14
approved these changes
Apr 28, 2023
bx80
approved these changes
Apr 28, 2023
AltamashShaikh
added a commit
that referenced
this pull request
May 2, 2023
#20630) * Added Wordpress installation guide for no-data and tracking code pages, #PG-2737 * UI screenshot updated * Updated UI steps as per design * Screenshot updated * Removed instructions in integration tab for WP * UI screenshot updated * Steps text updated * Final textual changes * Fixes test cases * PR changes applied * UI screenshot updated * PR changes * Refactired usages of wordpressUsed to cms * Updated screenshot * Updated screenshot * Update UI screenshot
bx80
pushed a commit
that referenced
this pull request
May 3, 2023
#20649) * Added WordPress installation guide for no-data and tracking code pages (#20630) * Added Wordpress installation guide for no-data and tracking code pages, #PG-2737 * UI screenshot updated * Updated UI steps as per design * Screenshot updated * Removed instructions in integration tab for WP * UI screenshot updated * Steps text updated * Final textual changes * Fixes test cases * PR changes applied * UI screenshot updated * PR changes * Refactired usages of wordpressUsed to cms * Updated screenshot * Updated screenshot * Update UI screenshot * Added WordPress installation guide for no-data and tracking code pages, #PG-2737 * Update FAQ link * Update link --------- Co-authored-by: Ben <ben.burgess@innocraft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added WordPress installation guide for no-data and tracking code pages.
Fixes: #PG-2737
Review