Removes deprecated javascript methods broadcast.init, broadcast.propagateAjax and broadcast.pageLoad #20610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ateAjax and broadcast.pageLoad
Merged
11 tasks
|
@sgiehl the code looks fine, re the documentation, yes the MatomoUrl class should be used. Created a PR for the docs here: matomo-org/developer-documentation#713 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The methods had been marked as deprecated and don't seem to be in use anymore.
@diosmosis Guess they got obsolete with the vue migration. Would you mind having a quick look and maybe propose an update to the documentation around that: https://developer.matomo.org/guides/working-with-piwiks-ui
It mentions that the full broadcast object is deprecated and the AngularJS location service should be used instead. I'm unsure if this deprecation is till in place or if the MatomoURL vue component should be used?
Review