Skip to content

Added GTM installation guide in no-data and tracking code pages #20606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

AltamashShaikh
Copy link
Contributor

Description:

Added GTM installation guide in no-data and tracking code pages.
Fixes: #PG-2730

Review

@AltamashShaikh AltamashShaikh added the Needs Review PRs that need a code review label Apr 20, 2023
@AltamashShaikh AltamashShaikh requested a review from sgiehl April 20, 2023 00:53
@AltamashShaikh AltamashShaikh changed the base branch from 5.x-dev to 4.x-dev April 20, 2023 00:54
@sgiehl sgiehl added this to the 4.14.x milestone Apr 20, 2023
* Added GTM installation guide in no-data and tracking code pages, #PG-2730

* Updated UI test

* Started mentioning the tracking code below step4 for onpremise

* UI screenshot updated

* Textual change

* Screenshot updated

* Changes to support steps override GTM steps by other plugins

* Updated unwanted line

* Updated UI screenshot

* UI screenshot updated

* Formatting changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sgiehl sgiehl merged commit 55d2b74 into 4.x-dev Apr 20, 2023
@sgiehl sgiehl deleted the cherry-pick-gtm branch April 20, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Development

Successfully merging this pull request may close these issues.

2 participants