Allow goals processed metrics to appear in API.getProcessedReport output #20589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matomo-org/core-reviewers can someone take a look at this PR for the 4.X release? I need it for the Looker Studio related work I'm doing. |
|
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
Merged
11 tasks
…put when filter_update_columns_when_show_all_goals is set as a query parameter
… if filter_show_goal_columns_process_goals is set to a single goal. this allows using it w/ API.getProcessedReport, w/o having to specify idGoal, which will end up being used in the search for report metadata
…show_all_goals is present in report metadata actions
75f09e7 to
cd02b57
Compare
sgiehl
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Changes:
filter_update_columns_when_show_all_goalsis supplied, and only one goal is supplied infilter_show_goal_columns_process_goals, use that goal as the default value foridGoal. This allows us to usefilter_update_columns_when_show_all_goalsw/oidGoal. Which is necessary for processed reports since ifidGoalis supplied, the code that searches for report metadata will try to match the report metadata$parametersw/['idGoal' => ...], which won't work for non-Goals reports.<metricTypesGoal>so metric types can be specified for<metricsGoal>and<processedMetricsGoal>.filter_update_columns_when_show_all_goalsandfilter_show_goal_columns_process_goalsas parameters so they will be forwarded to API methods in tests.conversion_ratefrom API report metadata if filter_update_columns_when_show_all_goals is present in report metadata actions.Review