Skip to content

Added site detection for cloudflare and updated noData page to mention cloudflare #20573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 12, 2023

Conversation

AltamashShaikh
Copy link
Contributor

Description:

Added site detection for cloudflare and updated noData page to mention cloudflare
Fixes: PG-2726
Cherry picked Cloudflare changes from 5.x-dev.

Review

…n cloudflare (#20566)

* Added site detection for cloudflare and updated noData page to mention cloudflare, #PG-2726

* UI fixes

* PR ceomments resolution

* Changed to ol from p

* Spacing for url and idsite fixed

* Updated with FAQ url

* Updated logic for updatedTab

* Created UI test for cloudflare

* UI test case updated

* Updated UI screenshots

* textual changes

* Updated UI screenshot

* Updated UI screenshot

* Tracking email code fixed
@AltamashShaikh AltamashShaikh added the Needs Review PRs that need a code review label Apr 12, 2023
@AltamashShaikh AltamashShaikh changed the base branch from 5.x-dev to 4.x-dev April 12, 2023 08:58
@AltamashShaikh AltamashShaikh requested a review from sgiehl April 12, 2023 12:18
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work as expected.

@sgiehl sgiehl merged commit 7156aad into 4.x-dev Apr 12, 2023
@sgiehl sgiehl deleted the PG-2726-cherrypick branch April 12, 2023 12:54
@sgiehl sgiehl added this to the 4.14.x milestone Apr 12, 2023
@sgiehl sgiehl added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. and removed Needs Review PRs that need a code review labels Apr 12, 2023
@sgiehl sgiehl modified the milestones: 4.14.x, 4.14.2 Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Development

Successfully merging this pull request may close these issues.

2 participants