Improve method to generate segment test url #20542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
commented
Mar 31, 2023
| action: 'getLastVisitsDetails', | ||
| segment: encSegment, | ||
| inPopover: 1, | ||
| }); |
There was a problem hiding this comment.
That one had been a bit too complex before. The URL for the visits log doesn't need to be built of the current url hash. Doing that actually caused comparison parameters and other unneeded parameters to be part of the loaded url. And in case the url or hash contained an unexpected count of ? this might even have failed and an incorrect url was loaded.
|
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
bx80
approved these changes
Apr 11, 2023
There was a problem hiding this comment.
Makes sense to me, much better to create a new clean URL with known parameters rather than attempting to adjust an existing URL in a potentially unknown format 👍
- Functional review done
- Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
- Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
- Security review done
- n/a Wording review done
- Code review done
- Already covered Tests were added if useful/possible
- None Reviewed for breaking changes
- n/a Developer changelog updated if needed
- n/a Documentation added if needed
- Existing documentation updated if needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
fixes #20532
Review