Get all numerics in one go for faster goal conversion calculation #20438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
approved these changes
Mar 9, 2023
This was referenced Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Noticed this one the other day while reviewing #20332
There were quite a few queries done to always find the correct archive IDs etc when we can maybe speed it slightly up.
It didn't make a huge difference I believe so we could also just close it although it might depend on the number of goals and overall load of the production system and how many archive records exist. Overall 30% of the time of the request was spent here though. This was a for a "range" period request.
The slow part was in
getArchiveIdswhere it caused 24 of the 25 callsThere was a failing test but it doesn't look related to this change.
Review