Skip to content

Fixed PHP 8.2 deprecation error in CustomDimensions #20437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 9, 2023
Merged

Fixed PHP 8.2 deprecation error in CustomDimensions #20437

merged 2 commits into from
Mar 9, 2023

Conversation

snake14
Copy link
Contributor

@snake14 snake14 commented Mar 8, 2023

Description:

While switching the plugins to build against PHP 8.2, I noticed a deprecation warning coming from the CustomDimensions ApiTest. This is correcting that deprecation warning.

PHP Deprecated:  Using ${var} in strings is deprecated, use {$var} instead in /home/runner/work/plugin-CustomAlerts/plugin-CustomAlerts/matomo/plugins/CustomDimensions/tests/System/ApiTest.php on line 94

Review

@snake14 snake14 added the Needs Review PRs that need a code review label Mar 8, 2023
@sgiehl sgiehl merged commit 86c2939 into 4.x-dev Mar 9, 2023
@sgiehl sgiehl deleted the pg-2665-php82-deprecation branch March 9, 2023 09:26
@bx80 bx80 changed the title Fixed PHP 8.2 deprecation error Fixed PHP 8.2 deprecation error in CustomDimensions Mar 16, 2023
@sgiehl sgiehl added this to the 4.14.0 milestone Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Milestone
4.14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@snake14 @sgiehl