Skip to content

Ensure empty widgets are loaded correctly #20435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Ensure empty widgets are loaded correctly #20435

merged 1 commit into from
Mar 8, 2023

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Mar 8, 2023

Description:

Some widgets might have no content when they are loaded. This currently causes the loading message to never disappear.
As an empty content is expected when e.g. loading the goal overview but no goals are configured yet, it's fine to simply place the empty content.

fixes #20430

Review

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Mar 8, 2023
@sgiehl sgiehl added this to the 4.13.4 milestone Mar 8, 2023
@sgiehl sgiehl requested a review from diosmosis March 8, 2023 14:27
@sgiehl sgiehl merged commit 58e691d into 4.x-dev Mar 8, 2023
@sgiehl sgiehl deleted the m20430 branch March 8, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Development

Successfully merging this pull request may close these issues.

Goals Overview stuck loading data
2 participants