Skip to content

Add referrerpolicy="no-referrer-when-downgrade" to noscript tracking code #20416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2023
Merged

Add referrerpolicy="no-referrer-when-downgrade" to noscript tracking code #20416

merged 1 commit into from
Mar 5, 2023

Conversation

bx80
Copy link
Contributor

@bx80 bx80 commented Mar 3, 2023

Description:

Fixes #20409

Adds referrerpolicy="no-referrer-when-downgrade" to the image tag used by the "Track users with JavaScript disabled" option for the tracking code.

Review

@bx80 bx80 added Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Mar 3, 2023
@bx80 bx80 added this to the 5.0.0 milestone Mar 3, 2023
@bx80 bx80 self-assigned this Mar 3, 2023
@bx80 bx80 changed the base branch from 4.x-dev to 5.x-dev March 3, 2023 00:47
@sgiehl sgiehl force-pushed the m20409-noscript-policy branch from 0ded740 to f22aa93 Compare March 3, 2023 14:38
sgiehl
sgiehl reviewed Mar 3, 2023
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change looks fine. I've rebased the branch, so the tests are triggered.
I assume a UI screenshot might need to be updated. Otherwise looks good to merge

@bx80 bx80 merged commit 13c2934 into 5.x-dev Mar 5, 2023
@bx80 bx80 deleted the m20409-noscript-policy branch March 5, 2023 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl left review comments

Assignees

@bx80 bx80

Labels
Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

Add referrerpolicy="no-referrer-when-downgrade" to noscript tracking code
2 participants
@bx80 @sgiehl