Added code to include schedule command for plugins while generating github action #20410
Conversation
|
@AltamashShaikh this looks fine. Just a general thought around that. Might it make sense to provide the cron value as parameter? That would allow us to differ it from plugin to plugin a bit. Otherwise all plugin actions would be triggered at the exact same time, causing a long action queue to block any further requests for some time. |
@sgiehl Makes sense, will update the PR 👍 |
|
@sgiehl Added |
There was a problem hiding this comment.
Works well for me using the new parameter. With --schedule-cron="0 3 * * 7" a cronjob is added to the test action, without the parameter no cronjob is added 👍
- Functional review done
- Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
- Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
- Security review done
- Wording review done
- Code review done
- n/a Tests were added if useful/possible
- None Reviewed for breaking changes
- n/a Developer changelog updated if needed
- Not needed Documentation added if needed
- Not needed Existing documentation updated if needed
Description:
Added code to include schedule command for plugins while generating github action.
Review