Skip to content

Try to set referrer attribution cookie when leaving the page if no tracking request was sent yet #19200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 30, 2022
Merged

Try to set referrer attribution cookie when leaving the page if no tracking request was sent yet #19200

merged 3 commits into from
May 30, 2022

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented May 9, 2022

Description:

fixes #18809

Review

@sgiehl sgiehl added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label May 9, 2022
@sgiehl sgiehl added this to the 4.11.0 milestone May 9, 2022
@sgiehl sgiehl added the Needs Review PRs that need a code review label May 10, 2022
@sgiehl sgiehl marked this pull request as ready for review May 10, 2022 07:00
@justinvelluppillai justinvelluppillai requested a review from bx80 May 17, 2022 02:41
bx80
bx80 approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@bx80 bx80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested using console logging, seems to work well 👍

@justinvelluppillai justinvelluppillai removed the Needs Review PRs that need a code review label May 18, 2022
@sgiehl sgiehl merged commit bd6b69c into 4.x-dev May 30, 2022
@sgiehl sgiehl deleted the m18809 branch May 30, 2022 16:21
@bx80 bx80 mentioned this pull request Feb 8, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@bx80 bx80 bx80 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
4.11.0
Development

Successfully merging this pull request may close these issues.

Fix referrer attribution cookie not set if no tracking request is sent, resulting in wrong attribution
3 participants
@sgiehl @bx80 @justinvelluppillai