Skip to content

Disable VisitorID segment site dependent #19083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 14, 2022
Merged

Disable VisitorID segment site dependent #19083

merged 3 commits into from
Apr 14, 2022

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Apr 12, 2022

Description:

fixes #18884

Review

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Apr 12, 2022
@sgiehl sgiehl added this to the 4.10.0 milestone Apr 12, 2022
bx80
bx80 reviewed Apr 12, 2022
View reviewed changes
Copy link
Contributor

@bx80 bx80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new testVisitorIdSegmentWithDisabledProfileForSite disabledProfile2 test is failing, looks like it's returning a visitorID when expected result is nothing.

@bx80 bx80 removed the Needs Review PRs that need a code review label Apr 12, 2022
@sgiehl
Copy link
Member Author

sgiehl commented Apr 13, 2022

@bx80 returning a visitorID is actually correct. The test had a differing result when running alone. Fixed that.

bx80
bx80 approved these changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@bx80 bx80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Tests now pass and also tested manually 👍

@sgiehl sgiehl force-pushed the visitoridsegment branch from 4c2c662 to 7b5b3d1 Compare April 14, 2022 09:19
@sgiehl sgiehl merged commit 4f780a6 into 4.x-dev Apr 14, 2022
@sgiehl sgiehl deleted the visitoridsegment branch April 14, 2022 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@bx80 bx80 bx80 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
4.10.0
Development

Successfully merging this pull request may close these issues.

Data protection: Hide visitor id in visits log if profile is disabled
2 participants
@sgiehl @bx80