Skip to content

Skip web server error logs for unsupported browser exceptions #19018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2022

Conversation

bx80
Copy link
Contributor

@bx80 bx80 commented Mar 29, 2022

Description:

Fixes #17738

Checks for the NotSupportedBrowserException type on the error message page and avoids writing a web server error log for these exception. (they can be captured in the application log instead if logging is set to debug)

Review

@bx80 bx80 added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Mar 29, 2022
@bx80 bx80 added this to the 4.9.0 milestone Mar 29, 2022
@bx80 bx80 self-assigned this Mar 29, 2022
@justinvelluppillai justinvelluppillai merged commit 3b91641 into 4.x-dev Mar 30, 2022
@justinvelluppillai justinvelluppillai deleted the m-17738-browser-unsupported-error branch March 30, 2022 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Development

Successfully merging this pull request may close these issues.

Don't log an error when not supported browser is used
2 participants