Allow calls to opcache_reset to be disabled in config #19948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinvelluppillai
suggested changes
Nov 6, 2022
There was a problem hiding this comment.
Nice one @samjf - just a couple of points but otherwise this looks pretty straightforward
- Normally we go for enable_ rather than disable_ for new configs, see https://developer.matomo.org/guides/piwiks-ini-configuration#naming
- This might be good to create a brief new FAQ for and/or at least mention in the developer changelog
|
Thanks @justinvelluppillai I'll make a fix for those and I'll keep those on file when making PRs in future. |
|
fyi @samjf we may also need to add an |
justinvelluppillai
suggested changes
Nov 14, 2022
CHANGELOG.md
Outdated
| @@ -27,6 +27,9 @@ The Product Changelog at **[matomo.org/changelog](https://matomo.org/changelog)* | |||
|
|
|||
| * The methods `setExcludedReferrers` and `getExcludedReferrers` have been added to the JavaScript tracker. They allow setting and receiving the referrers the JavaScript tracker should ignore. If a referrer matches an entry on that list, it will not be passed with the tracking requests and the attribution cookie will stay unchanged. This can for example be used if you need to forward your users to an external service like SSO or payment and don't want any visits or conversions being attributed to those services. | |||
|
|
|||
| ### New config.ini.php settings | |||
There was a problem hiding this comment.
This is no longer in 4.12.0 but 4.12.4 (if we merge it now).
There was a problem hiding this comment.
I didn't realise it was by patch version, but it makes sense hehe. I'll change this now.
justinvelluppillai
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
ref: CLOUD-798
From time to time, we experience corrupt opcaches that cause outages which can cause various random errors to occur. After investigating we found that certain processes we use call Matomo console commands which result in the reset of the opcache. We believe it is likely that multiple concurrent opcache resets might result in the corrupt opcache.
This PR simply provides a configuration switch which can be used to disable opcache resets. This is off by default. When enabled this configuration will allow better control over the opcache and will likely allow us to avoid opcache corruption.
This configuration change was added in the cache section of the configuration as such:
Cache['disable_opcache_reset']Review