update autocomplete on html to on and off
#19873
Conversation
update autocomplete from true and false to on and off
on and offtrue and false to on and off
true and false to on and offon and off
|
@peterhashair The change looks fine, but you don't need to request a review from me for every vue change now that the migration is nearing completion. Core reviewers can review them. |
There was a problem hiding this comment.
This might not work as expected in some cases. E.g. when setting autocomplete=off directly, the change here would convert this to autocomplete=on.
Additionally this will add a autocomplete=off to all input fields that don't define a autocomplete. Not sure if that is expected.
Also we should consider to use the autocomplete attribute in a way, where we not only set it to on or off, but provide which data to autofill (or not).
For now I would say we should change all occurrences of autocomplete=false to autocomplete=off, so we later have the possibility to use something like autocomplete="password"
|
@sgiehl that makes more sense, I guess, we can change autocomplete from boolean to string, will update all the places that appear. |
update autocomplete to string
|
@sgiehl any suggestion on that PR, I update |
Description:
Fixes: #19872
update autocomplete on HTML from true and false to
onandoffReview