Use materializecss/materialize instead of Dogfalo/materialize #19622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fc5e107 to
bb3bb94
Compare
bb3bb94 to
c1e6929
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
c1e6929 to
46abf83
Compare
This comment was marked as outdated.
This comment was marked as outdated.
9dc4e7e to
b3b8fa2
Compare
a95d7af to
0c51d30
Compare
1a42673 to
45f4ca9
Compare
97bd658 to
89b4189
Compare
89b4189 to
ff635fa
Compare
ff635fa to
6a8524d
Compare
b3888f1 to
cde0a2a
Compare
cde0a2a to
fc732f6
Compare
bx80
approved these changes
Mar 27, 2023
There was a problem hiding this comment.
I've also done some manual testing to check for any obvious UI layout breakages, I can't see any issues 👍
- Functional review done
- Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
- Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
- Security review done
- n/a Wording review done
- Code review done
- Tests updated Tests were added if useful/possible
- None Reviewed for breaking changes
- not needed Developer changelog updated if needed
- n/a Documentation added if needed
- n/a Existing documentation updated if needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
fixes #16368
Review