[Vue] make all scripts load via defer #19514
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rg/matomo into vue-remove-angularjs-MultiSites
…-CoreHome-CorePluginsAdmin
…angularjs-CoreHome-CorePluginsAdmin
…/matomo into vue-remove-angularjs-Morpheus
…angularjs-MobileMessaging
…omo-org/matomo into vue-remove-angularjs-MobileMessaging
…rjs-CoreHome-CorePluginsAdmin
…org/matomo into vue-remove-angularjs-Marketplace
…omo-org/matomo into vue-remove-angularjs-MobileMessaging
…ngularjs-CoreHome-CorePluginsAdmin
…tomo into vue-remove-angularjs-Login
…omo into vue-remove-angularjs-Live
…oreHome-CorePluginsAdmin
…tomo-org/matomo into vue-remove-angularjs-LanguagesManager
…e-remove-angularjs-final
|
If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'. |
…e-remove-angularjs-final
|
This PR was last updated more than one month ago, maybe it's time to close it. Please check if there is anything we still can do or close this PR. ping @matomo-org/core-reviewers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR is based off #19502.
Fixes #18982.
Changes:
deferattribute.$(document).ready(in inline<script>s w/window.addEventListener('DOMContentLoaded',(or just replaced some).development:compute-js-asset-sizecommand, also printing total size of vanilla JS (non-Vue code) by plugin.CoreHome.DataTabledirective to initialize datatables instead of inline scripts. Similarly added LegacyUIControl directive for _uiControl.twig files, and similar directives for UserCountryMap widgets.UserCountryMapLegacyModuleto house vanilla JS objects related to realtime/visitor map.UserCountryMapshouldn't be used since it is also the name of a plugin w/ Vue code.Review