-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
[Vue] remove angularjs from CoreHome and CorePluginsAdmin #19496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Vue] remove angularjs from CoreHome and CorePluginsAdmin #19496
Conversation
…ularjs-CoreHome-CorePluginsAdmin
…larjs-PrivacyManager
…gularjs-CoreHome-CorePluginsAdmin
…rg/matomo into vue-remove-angularjs-MultiSites
…-CoreHome-CorePluginsAdmin
…angularjs-CoreHome-CorePluginsAdmin
…/matomo into vue-remove-angularjs-Morpheus
…angularjs-MobileMessaging
…omo-org/matomo into vue-remove-angularjs-MobileMessaging
…rjs-CoreHome-CorePluginsAdmin
…org/matomo into vue-remove-angularjs-Marketplace
submodules have been reviewed and merged |
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a comment. Otherwise the code looks fine so far. Have not yet clicked through the UI much, will do that tomorrow...
@diosmosis would you mind checking why the javascript tests are failing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks everything works now 👍
* get propagation of property to child vue-entry components to work, if strangely * add missing translations * remove import added by phpstorm * try to fix timing error in test * try removing prefix/suffix entirely from vue entry properties * fix issues from UI tests * remove leading hash characters from hash value * do not attempt to print if puppeteer context is destroyed * update screenshot * do not abort ajax requests when loading the sidebar * revert back to suffixing an underscore * avoid random failure * built vue files * add missing vue-entry property + add missing translations * fixing UI tests locally * update screenshots * update CustomAlerts submodule * add missing translations * fix spacing * couple fixes * more ui test fixes * make sure installation umd is loaded during installation (as well as translations) * couple small UI test fixes * Fix component name case. * built vue files * do not use html_attr to escape and in UI tests replace path with escaped slashes so json data gets replaced * move UploadPluginDialog to CorePluginsAdmin so it will be available when internet access is not available and the Marketplace plugin is deactivated * correct typing for feedback question input * update screenshots * revert last tweak * styling tweak * update screenshots and styling tweak * fix attribute * Allow composer plugins for dev dependency codesniffer to fix travis builds. * keep dependent class and rename * styling tweaks * update expected screenshot * update screenshots * comma spacing tweak * update screenshots + fix v-show condition * some small fixes * fix styling and formatting issues * fix spacing issue * fix property name * update expected screenshots * get to load in UI * getting dashboard settings control to work * styling tweaks * fix html attribute output for singlemetricview * fix vue-entry elements * update expected screenshot * fixing UI test issues, reintroduce compileAngularComponents (will remove calls in CoreHome PR) * move function to correct class * fix order of array elements * fixing some more issues * hide the dashboard manager on initial display as before * styling fixes * fix styles for widgetized glossary * update expected screenshots * fixing DashboardManager UI test that previously used the uiControlObject property * update device detection demo to be accurate * update expected screenshots * fix race condition in dashboard ajax requests/aborts * start removing angularjs from CoreHome * remove more angularjs code * remove angularjs from CustomDimensions plugin * removing some angularjs files * remove use of history service, the use of $location from MatomoUrl and the piwikApi service * remove angularjs service module and filters * removing more angularjs references * remove more angular related code, including getAngularDependency() * update submodules to vue-remove-angularjs branches * try replacing angularjs expression parsing w/ mathjs/number * logical operator fixes * only import what is needed for math.js * remove some functionality * optimize math.js use * convert zen mode code, add --bail option and some output to vue:build * remove ng-app directive in twig layouts * ajaxhelper.adapter.ts still required for vanilla ajaxHelper() object * remove ng-cloak use * fix datatableactions.vue errors * do not propagate id param in vue-entry uses * remove pointless defer * get zen mode to work, fix couple issues in headermessage vue-entry usage * move more data table action icon code to vue component from dataTable.js + fix use of angular in ui test JS override code * couple more data table actions fixes * UI test fixes + ng-non-bindable no longer needed * fix more test issues + update some screenshots * remove another use of isAngularRenderingThePage * revert screenshot change * fixing more issues * move inline script to vue directive + fix a couple vue warnings * built vue files * remove inline script in system check widget * fix some more datatableactions issues * use VueEntryContainer in _singleWidget.twig * remove unused inline script from _donate.twig * update expected screenshots * fix hide flat icon code * updating screenshots and try to fix random failure * fix numeric conversion * update expected screenshots * update screenshots * use common method to load umd file * get languages dropdown to work * only add menu translations if installed * make sure datatableactions vue entry is completely rendered before initing datatable * correct enriched-headline selector * update VisitorGenerator submodule * do not load menu translations during updater as well * update expected screenshots * update screenshot * update submodule * update expected screenshot * update submodule * remove duplicate translations * built vue files * Fix various stuff that came in again through merge * fix submodule ref * built vue files * remove unexpected else in twig template * fix menu translation check * readd ajaxhelper * update some screenshots and fix a merge error * fix another merge error * update screenshots and remove ng-cloak from tagmanager page * fix omnifixture sql * tests/UI/expected-screenshots/UIIntegrationTest_api_listing.png * add description column to tagmanager tables missing it in omnifixture dump * update expected screenshots * add delta to assert * update submodule * update LoginLdap submodule * update expected screenshot * update submodule * reflect reversion made in 4.x-dev for this file * remove reference to removed file in unit test * update expected URLs in test Co-authored-by: sgiehl <stefan@matomo.org> Co-authored-by: sgiehl <sgiehl@users.noreply.github.com>
Description:
This PR is based off every vue-remove-angularjs- PR and should be merged after they are all merged.
Changes:
Review