Skip to content

Add 429 response Code UI #19433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Jul 20, 2022
Merged

Add 429 response Code UI #19433

merged 22 commits into from
Jul 20, 2022

Conversation

peterhashair
Copy link
Contributor

@peterhashair peterhashair commented Jun 29, 2022 •
edited
Loading

Description:

Fixes : #19233

add 429 notification to javascript and dashboard load.

Review

Peter and others added 6 commits June 21, 2022 15:41
add template
34b55d9 
add template
Update AjaxHelper.ts
407cbe1 
update error code
add widget rate limit loader
5c6cd7e 
add widget rate limit loader
@peterhashair
built vue files
c596953
Merge branch '4.x-dev' into m19233
6c988c7 
# Conflicts:
#	plugins/CoreHome/vue/dist/CoreHome.umd.min.js
@peterhashair
built vue files
ce9d224
sgiehl
sgiehl reviewed Jun 29, 2022
View reviewed changes
Peter and others added 4 commits June 30, 2022 11:33
remove file
cd3960b 
remove file
update wording
5a23f30 
update wording
Merge branch '4.x-dev' into m19233
a5595a6 
# Conflicts:
#	plugins/CoreHome/vue/dist/CoreHome.umd.min.js
@peterhashair
built vue files
2c4c746
@peterhashair peterhashair marked this pull request as ready for review July 3, 2022 22:46
@peterhashair peterhashair added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jul 3, 2022
Peter and others added 2 commits July 4, 2022 11:04
@justinvelluppillai justinvelluppillai added the Needs Review PRs that need a code review label Jul 4, 2022
peterhashair
peterhashair commented Jul 7, 2022
View reviewed changes
Peter Zhang and others added 3 commits July 7, 2022 15:34
Update lang/en.json
5b22cf1
Merge branch '4.x-dev' into m19233
b0a9aa2 
# Conflicts:
#	plugins/CoreHome/vue/dist/CoreHome.umd.min.js
@peterhashair
built vue files
911f6f7
@peterhashair peterhashair requested a review from bx80 July 12, 2022 23:13
bx80
bx80 suggested changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@bx80 bx80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well. I've left a few comments on how we could improve the messaging.

Peter Zhang and others added 7 commits July 13, 2022 16:39
@bx80
Update plugins/CoreHome/vue/src/AjaxHelper/AjaxHelper.ts
0657c10 
Co-authored-by: Ben Burgess <88810029+bx80@users.noreply.github.com>
update text and rate limit
12b09ba 
update text and rate limit
Merge branch 'm19233' of github.com:matomo-org/matomo into m19233
f271d3d
@peterhashair
built vue files
0ad705b
Update en.json
53ed558 
remove api docs for now
Merge branch '4.x-dev' into m19233
88b028b 
# Conflicts:
#	plugins/CoreHome/vue/dist/CoreHome.umd.min.js
@peterhashair
built vue files
950e6c6
@peterhashair peterhashair merged commit 0eeb042 into 4.x-dev Jul 20, 2022
@peterhashair peterhashair deleted the m19233 branch July 20, 2022 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl left review comments

+1 more reviewer

@bx80 bx80 bx80 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle 429 response code within UI
4 participants
@peterhashair @sgiehl @bx80 @justinvelluppillai