update big int on cookie expire time to datatime format #18179
Merged
+61
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update int 30 years to string
sgiehl
reviewed
Oct 19, 2021
added 3 commits
October 20, 2021 00:44
update cookie time
update one error
update comments
added 3 commits
October 20, 2021 00:55
remove a not used else
group test into simple functions
update typo
sgiehl
reviewed
Oct 19, 2021
|
Seems there are also various tests failing... |
update warning to try catch
|
@sgiehl sorry, that's my bad, it actually fired a warning instead of an error. |
added 4 commits
October 20, 2021 10:46
add warning to exception handler
restore test after cookie
|
Not sure that's the best approach, it actually throws a warning to an exception enters the catch. Then reset it back. Line 478 in 393bfa7 |
remove GMT
revert test back
sgiehl
reviewed
Oct 20, 2021
tsteur
reviewed
Oct 20, 2021
added 2 commits
October 21, 2021 09:28
remove warning
remove time to fix bit 32
sgiehl
requested changes
Oct 22, 2021
|
@sgiehl that's looks great, let me update it. |
update cookie, and function
sgiehl
reviewed
Oct 26, 2021
sgiehl
approved these changes
Oct 26, 2021
This was referenced Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes: #18019
add a function in cookies. it accepts timestamp (int) and string eg:
+ 30 yearsto avoid big int in PHP 32 bitReview