Skip to content

Revert "if not comparing, set show_limit_control to true for Evolution Report" #18010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 15, 2021
Merged

Revert "if not comparing, set show_limit_control to true for Evolution Report" #18010

merged 1 commit into from
Sep 15, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Sep 15, 2021

Reverts #17987

This made it impossible to overwrite the value in reports as the beforeRender method is called after the method that is normally used to configure the view.

@sgiehl sgiehl merged commit 4f6275d into 4.x-dev Sep 15, 2021
@sgiehl sgiehl deleted the revert-17987-m-17965 branch September 15, 2021 14:57
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgiehl @justinvelluppillai