Skip to content

Migrate usersmanager root component to Vue #18583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 805 commits into from
Feb 14, 2022
Merged

Migrate usersmanager root component to Vue #18583

merged 805 commits into from
Feb 14, 2022

Conversation

diosmosis
Copy link
Member

@diosmosis diosmosis commented Jan 6, 2022 •
edited
Loading

Description:

This PR is based off of #18582.

Changes:

  • Add support for bulk fetches to AjaxHelper.fetch.
  • Export v-tooltips directive + add default content transform.
  • Add lazyScrollToContent() function to matomo helper global.
  • Migrate matomo-users-management component to vue.

image

Review

@diosmosis
fix dropdown class/directive name
ea46bee
@diosmosis
fix overlay test
d636b3d
@diosmosis
Merge branch 'vue-popover-handler' into vue-core-home-common-directives
e991934
@diosmosis
Merge branch '4.x-dev' into vue-corehome-components-1
2114167
@diosmosis
Merge branch 'vue-corehome-components-1' into vue-ajax-form
90196a8
@diosmosis
remove unintended changes
b94d66f
@diosmosis
remove unintended changes
4641557
@diosmosis
Merge branch 'vue-ajax-form' into vue-popover-handler
1212ffd
@diosmosis
Merge branch 'vue-popover-handler' into vue-core-home-common-directives
33303ac
@diosmosis
migrate archiving controller
8167767
@diosmosis
do not do a passthrough transpile of vue typescript, and fix many typ…
69d3440 
…escript errors in existing code
@diosmosis
more typescript fixes
3c0fff0
@diosmosis
even more fixes
1bd183e
@diosmosis
workarounds to fix recursive typing issues
b9fb003
@diosmosis
get corehome to build w/ full typescript build and output type defini…
5b53519 
…tions to local dir
@diosmosis
get outputted typings to be used when compiling other plugins and fix…
54ac1b1 
… typescript issues in CorePluginsAdmin
@diosmosis
readd corehome umd
0b84bf2
@diosmosis
fix typescript errors in ExampleVue plugin
eb610e4
@diosmosis
fix feedback typescript errors
adc7933
@diosmosis
Merge branch 'vue-no-passthrough-transpile' into vue-coreadminhome-ar…
8b41d38 
…chiving
@diosmosis
Merge branch '4.x-dev' into vue-corehome-components-1
7584a5d
@diosmosis
rebuild
55edfbd
@diosmosis
migrate branding controller and get to build
528f538
@diosmosis
fix issues and get to work
05e56bd
@diosmosis
rebuild
d23416c
@diosmosis
fix notification scroll
59eecd6
@diosmosis
migrate smtp settings controller in coreadminhome
f854475
@diosmosis
get to work
37e63aa
@diosmosis
migrate js tracking code generator and get to build
0d990c4
@diosmosis
migrate image tracking code generator and get to build
c089247
@diosmosis diosmosis added Do not close PRs with this label won't be marked as stale by the Close Stale Issues action Needs Review PRs that need a code review and removed Stale The label used by the Close Stale Issues action labels Feb 3, 2022
@diosmosis diosmosis marked this pull request as ready for review February 3, 2022 15:12
@sgiehl sgiehl mentioned this pull request Feb 8, 2022
Merged
11 tasks
@diosmosis diosmosis mentioned this pull request Feb 10, 2022
Closed
peterhashair
peterhashair reviewed Feb 13, 2022
View reviewed changes
Copy link
Contributor

@peterhashair peterhashair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably needs to update those failed screenshots, but other than that looks good to me.

@diosmosis diosmosis merged commit 4350dfb into 4.x-dev Feb 14, 2022
@diosmosis diosmosis deleted the vue-usersmanager-5 branch February 14, 2022 15:02
@justinvelluppillai justinvelluppillai changed the title [Vue] migrate usersmanager root component to Vue Migrate usersmanager root component to Vue Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@peterhashair peterhashair peterhashair left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Do not close PRs with this label won't be marked as stale by the Close Stale Issues action Needs Review PRs that need a code review
Milestone
4.8.0
Development

Successfully merging this pull request may close these issues.
5 participants
@diosmosis @peterhashair @sgiehl @bx80 @weblate