remove acceptedValues from PageUrl #17895
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@geekdenz There's a test that needs to be updated. See https://app.travis-ci.com/github/matomo-org/matomo/jobs/531879021#L763 |
Sorry for the delay. It was a simple fix by copying the processed to expected xml. The difference is expected. I checked. |
sgiehl
approved these changes
Aug 20, 2021
There was a problem hiding this comment.
Looks good now.
@mattab I'm not fully sure what the intention of the original issue was. Is it fine that this hint will be removed from UI, but I guess also from
https://developer.matomo.org/api-reference/reporting-api-segmentation
|
@sgiehl yes it was meant to remove it from both places. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #15322
Description:
Remove the PageUrl->acceptedValues property to effectively remove it from the tooltip (title attribute).
Does this have knock-on effects elsewhere?
Review