Improve I/O performance by not writing placeholder files when they already exist #17873
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #17870
Description:
When matomo checks if directories are writeable it puts empty index files in the directories to prevent directory listing. This causes a few unnecessary writes. This fix checks if the file exists to potentially skip writing and reduce IO.
Note: We use is_file not file_exists as slightly faster: #16552
Review