Skip to content

Do not log a failed login if a valid app token_auth is sent #17867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 10, 2021
Merged

Do not log a failed login if a valid app token_auth is sent #17867

merged 1 commit into from
Aug 10, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Aug 9, 2021

Description:

Currently when sending a valid token_auth with any API request, a failed login is logged when the force_api_session parameter is set in the request as well.

refs L3-131

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl
Do not log a failed login if a valid app token_auth is sent with the …
2ca6d7d 
…request, but force_api_session parameter is present as well
@sgiehl sgiehl added the Needs Review PRs that need a code review label Aug 9, 2021
@sgiehl sgiehl added this to the 4.5.0 milestone Aug 9, 2021
@sgiehl sgiehl merged commit 1c287f1 into 4.x-dev Aug 10, 2021
@sgiehl sgiehl deleted the tokenauthsession branch August 10, 2021 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diosmosis diosmosis diosmosis approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Milestone
4.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sgiehl @diosmosis