Skip to content

Remove provider lookup from core #16756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 14, 2020
Merged

Remove provider lookup from core #16756

merged 6 commits into from
Dec 14, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Nov 19, 2020

Description:

This should be done in the provider plugin instead.

requires matomo-org/plugin-Provider#7
fixes #16712

The Provider plugin submodule needs to be updated before merge (after the plugin PR was merged)

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl
remove Provider dimension from core
a2b6175 
this should be handled in Provider plugin now
@sgiehl sgiehl added the Needs Review PRs that need a code review label Nov 19, 2020
@sgiehl sgiehl added this to the 4.1.0 milestone Nov 19, 2020
@sgiehl sgiehl force-pushed the removeproviderdimension branch from cf6718e to de6f4f7 Compare November 19, 2020 16:41
@sgiehl sgiehl mentioned this pull request Nov 24, 2020
Merged
@diosmosis diosmosis merged commit 9bf10dc into 4.x-dev Dec 14, 2020
@diosmosis diosmosis deleted the removeproviderdimension branch December 14, 2020 02:40
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diosmosis diosmosis diosmosis approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.

Clarify that tracking ISP data requires Provider plugin
3 participants
@sgiehl @diosmosis @mattab